Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Reduce scrollbar width on TOC #41148

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 17, 2024

I saw this done in Docusaurus https://github.com/facebookincubator/infima/blob/aa1eebd35cdaee3348eb47315774882464cb522f/packages/core/styles/utilities/custom-scrollbar.pcss#L17 while I was browsing a docs of another project. They also do it for the side nav tab, but this feels wrong. So I opened a PR, quick-win.

One step closer to address #38710. A previous iteration was done in #37770.

Before
SCR-20240217-ulre

After
SCR-20240217-ulps

Ideally, we could have used https://stackoverflow.com/a/68860350/2801714 but Chrome is so buggy with it, it's not ready yet.

@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Feb 17, 2024
@mui-bot
Copy link

mui-bot commented Feb 17, 2024

Netlify deploy preview

https://deploy-preview-41148--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 484dd76

@oliviertassinari oliviertassinari changed the title [docs–infra] Reduce scrollbar width on ROC [docs-infra] Reduce scrollbar width on ROC Feb 17, 2024
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Hadn't come across this CSS property before 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants