Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove enzyme #42706

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[test] Remove enzyme #42706

merged 2 commits into from
Jun 26, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 21, 2024

Part of #42454

Completely removes Enzyme from the repo.

@aarongarciah aarongarciah added test on hold There is a blocker, we need to wait core Infrastructure work going on behind the scenes labels Jun 21, 2024
@mui-bot
Copy link

mui-bot commented Jun 21, 2024

Netlify deploy preview

https://deploy-preview-42706--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 78b9f6c

@aarongarciah aarongarciah mentioned this pull request Jun 22, 2024
4 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 24, 2024
stream: false,
// required by enzyme > cheerio > parse5
util: require.resolve('util/'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working fine without this line.

@aarongarciah aarongarciah marked this pull request as ready for review June 26, 2024 16:50
@aarongarciah
Copy link
Member Author

This is now ready to review @DiegoAndai

@aarongarciah aarongarciah added React 19 support PRs required to support React 19 and removed on hold There is a blocker, we need to wait labels Jun 26, 2024
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aarongarciah aarongarciah merged commit 22be6cf into mui:next Jun 26, 2024
21 checks passed
@aarongarciah aarongarciah deleted the remove-enzyme branch June 26, 2024 18:45
This was referenced Jul 5, 2024
@aarongarciah aarongarciah added the dependencies Update of dependencies label Jul 5, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies React 19 support PRs required to support React 19 test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants