-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Bump React to 18.3.1 #42846
Merged
Merged
[core] Bump React to 18.3.1 #42846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
dependencies
Update of dependencies
core
Infrastructure work going on behind the scenes
labels
Jul 5, 2024
Netlify deploy previewhttps://deploy-preview-42846--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
aarongarciah
added
React 19 support
PRs required to support React 19
cherry-pick
The PR was cherry-picked from the next branch
labels
Jul 5, 2024
aarongarciah
force-pushed
the
react-18.3.1
branch
from
July 5, 2024 11:55
9c5333a
to
61dc4fa
Compare
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 5, 2024
Co-authored-by: Aarón García Hervás <aaron@mui.com>
aarongarciah
force-pushed
the
react-18.3.1
branch
from
July 8, 2024 15:24
601d6d9
to
e4402fa
Compare
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jul 8, 2024
Finally a bump of @testing-library/dom and @testing-library/react was required to have a compatible React 18.3.1 testing setup, otherwise tests would fail due to some wrong types. |
DiegoAndai
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This was referenced Aug 2, 2024
This was referenced Aug 2, 2024
This was referenced Aug 12, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick
The PR was cherry-picked from the next branch
core
Infrastructure work going on behind the scenes
dependencies
Update of dependencies
React 19 support
PRs required to support React 19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents of this PR:
act
is no longer exported fromreact-dom/test-utils
and is now exported fromreact
. Older versions of@testing-library/react
point toact
inreact-dom/test-utils
, so we need to upgrade to a newer version. This can't be done in a separate PR because of some incompatible types.We're backporting all changes to support React 18.3.1 from
next
tomaster
. These are the changes to backport fromnext
before we can merge this PR:defaultProptypes
warning. Included in this PR.