Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove react-test-renderer #42784

Merged
merged 4 commits into from
Jun 30, 2024
Merged

[core] Remove react-test-renderer #42784

merged 4 commits into from
Jun 30, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 28, 2024 •
edited
Loading

This PR removes the react-test-renderer dependency, the last test using it in describeConformance, and other related code.

Context:

  • react-test-renderer was deprecated in React 18.3
  • React 19 will start throwing a warning when using react-test-renderer

@aarongarciah aarongarciah added test core Infrastructure work going on behind the scenes needs cherry-pick The PR should be cherry-picked to master after merge React 19 support PRs required to support React 19 labels Jun 28, 2024
@aarongarciah aarongarciah mentioned this pull request Jun 28, 2024
Merged
15 tasks
@aarongarciah aarongarciah requested a review from a team June 28, 2024 15:51
@mui-bot
Copy link

mui-bot commented Jun 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42784--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 593fb75

LukasTy
LukasTy approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏 💯 🚀

@aarongarciah aarongarciah merged commit fea558d into mui:next Jun 30, 2024
19 checks passed
@aarongarciah aarongarciah deleted the remove-react-test-renderer branch June 30, 2024 14:20
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
Merged
13 tasks
@aarongarciah aarongarciah added the dependencies Update of dependencies label Jul 5, 2024
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
Merged
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@aarongarciah @joserodolfofreitas
[core] Remove react-test-renderer (mui#42784)
3f578ce
@DiegoAndai DiegoAndai mentioned this pull request Nov 15, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies needs cherry-pick The PR should be cherry-picked to master after merge React 19 support PRs required to support React 19 test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongarciah @mui-bot @LukasTy