Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mui-utils][test] Remove usages of deprecated react-dom APIs #42780

Merged

Conversation

aarongarciah
Copy link
Member

In preparation for #42047, we need to remove react-dom deprecated APIs, namely, render and unmountComponentAtNode. This PR replaces these APIs with createRenderer, our React Testing Library wrapper.

@aarongarciah aarongarciah added test package: utils Specific to the @mui/utils package React 19 support PRs required to support React 19 labels Jun 28, 2024
@aarongarciah aarongarciah mentioned this pull request Jun 28, 2024
15 tasks
@mui-bot
Copy link

mui-bot commented Jun 28, 2024

Netlify deploy preview

https://deploy-preview-42780--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 303e01e

@aarongarciah aarongarciah force-pushed the remove-react-dom-deprecated-apis branch from 0312f13 to c16bd9f Compare June 28, 2024 11:02
@aarongarciah aarongarciah marked this pull request as draft June 28, 2024 11:16
@aarongarciah aarongarciah force-pushed the remove-react-dom-deprecated-apis branch from c16bd9f to 21d1ff5 Compare June 28, 2024 11:21
@aarongarciah aarongarciah marked this pull request as ready for review June 28, 2024 11:31
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer and closer to React 18.3 🎉

@aarongarciah aarongarciah added the needs cherry-pick The PR should be cherry-picked to master after merge label Jun 28, 2024
@aarongarciah
Copy link
Member Author

@DiegoAndai ready for the last pass

@aarongarciah
Copy link
Member Author

Oops, one sec, I need to remove a spare React.cloneElement.

@aarongarciah
Copy link
Member Author

Now is ready

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aarongarciah aarongarciah merged commit 38e3d65 into mui:next Jul 1, 2024
19 checks passed
@aarongarciah aarongarciah deleted the remove-react-dom-deprecated-apis branch July 1, 2024 16:05
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
13 tasks
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs cherry-pick The PR should be cherry-picked to master after merge package: utils Specific to the @mui/utils package React 19 support PRs required to support React 19 test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants