Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix CI on v5.x branch #43564

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 1, 2024

The v5.x branch is full or failing CI builds, proof: https://github.com/mui/material-ui/commits/v5.x/. This can't work, so here is a quick fix.

  1. I ran npx update-browserslist-db@latest and commit the changes.
  2. I had

Error [BrowserslistError]: [BABEL] /Users/oliviertassinari/material-ui/packages/mui-styled-engine/src/GlobalStyles/GlobalStyles.js: Unknown version 74 of op_mob (While processing: "/Users/oliviertassinari/material-ui/node_modules/.pnpm/@babel+preset-env@7.23.9_@babel+core@7.25.2/node_modules/@babel/preset-env/lib/index.js")\n' +

I looks like that version never existed https://caniuse.com/ciu/comparison

SCR-20240901-sfcr

if I understand browserslist/browserslist#537 correctly.

  1. Some of the tests were outdated
  2. Some of the formatting script run an different output

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes v5.x labels Sep 1, 2024
@mui-bot
Copy link

mui-bot commented Sep 1, 2024

Netlify deploy preview

https://deploy-preview-43564--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 7386bbb

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Sep 1, 2024
Janpot
Janpot previously approved these changes Sep 2, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess technically you'd want to choose a lower version rather than a higher one, but if it always reverted to the desktop version before and we're not altering that one there shouldn't be a problem. (I guess?)

@oliviertassinari
Copy link
Member Author

I guess technically you'd want to choose a lower version rather than a higher one

@Janpot The problem is that Opera Mobile 12 was released so long ago, e.g. v18 was in 2013: https://blogs.opera.com/desktop/2013/11/opera-18-landed/. Opera Mobile 80 uses Chromium 120 which is 2023 ish.

Now, yeah, I don't want us to be depending on the next time we get this error: https://app.circleci.com/pipelines/github/mui/material-ui/137830/workflows/405559b1-5afa-4b28-8711-c615bf96bd30/jobs/743026

SCR-20240903-btvy

Instead, I'm going with browserslist/browserslist#543 (comment). No thanks, we want to keep our build idempotent.

@oliviertassinari oliviertassinari merged commit 6dcf4d6 into mui:v5.x Sep 3, 2024
16 checks passed
@oliviertassinari oliviertassinari deleted the fix-ci-browserlist branch September 3, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes regression A bug, but worse v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants