-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix CI on v5.x branch #43564
[core] Fix CI on v5.x branch #43564
Conversation
e6fd1e5
to
bf9dc34
Compare
Netlify deploy previewhttps://deploy-preview-43564--material-ui.netlify.app/ @material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
ce16e7d
to
d785cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess technically you'd want to choose a lower version rather than a higher one, but if it always reverted to the desktop version before and we're not altering that one there shouldn't be a problem. (I guess?)
@Janpot The problem is that Opera Mobile 12 was released so long ago, e.g. v18 was in 2013: https://blogs.opera.com/desktop/2013/11/opera-18-landed/. Opera Mobile 80 uses Chromium 120 which is 2023 ish. Now, yeah, I don't want us to be depending on the next time we get this error: https://app.circleci.com/pipelines/github/mui/material-ui/137830/workflows/405559b1-5afa-4b28-8711-c615bf96bd30/jobs/743026 Instead, I'm going with browserslist/browserslist#543 (comment). No thanks, we want to keep our build idempotent. |
The
v5.x
branch is full or failing CI builds, proof: https://github.com/mui/material-ui/commits/v5.x/. This can't work, so here is a quick fix.npx update-browserslist-db@latest
and commit the changes.I looks like that version never existed https://caniuse.com/ciu/comparison
if I understand browserslist/browserslist#537 correctly.