Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Migrate some .gif to <video> #43945

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 30, 2024

This issue has been around for a while https://app.ahrefs.com/site-audit/2944028/data-explorer?columns=pageRating%2Curl%2ChttpCode%2CcontentType%2Csize%2CloadingTime%2CincomingImage&current=27-09-2024T022449&filterId=ad5863095a819f761d42b32931a29649&issueId=c64d8113-d0f4-11e7-8ed1-001e67ed4656&sorting=-size.

SCR-20240930-osan

Using a video over a gif allows to reduce the bandwidth use by x3 and also to show control, which is great for >10s videos.

There are likely more gif to convert but I don't have bandwidth for this. I wanted to show the example and remove the noise from the crawl. Once we fix the blog pagination #40941 (the blog is not crawlable correctly today by bots), ahrefs should report them all.

I did the conversion using https://stackoverflow.com/questions/31781238/using-ffmpeg-to-convert-gif-to-mp4-output-doesnt-play-on-android.

Before: https://deploy-preview-43942--material-ui.netlify.app/blog/introducing-the-row-grouping-feature/
After: https://deploy-preview-43945--material-ui.netlify.app/blog/introducing-the-row-grouping-feature/

cc @mui/docs-infra for awareness, let's avoid .gif.

@oliviertassinari oliviertassinari marked this pull request as ready for review September 30, 2024 14:41
@oliviertassinari oliviertassinari added performance blog scope: docs-infra Specific to the docs-infra product labels Sep 30, 2024
@mui-bot
Copy link

mui-bot commented Sep 30, 2024

Netlify deploy preview

https://deploy-preview-43945--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 49ffc29

@mnajdova
Copy link
Member

mnajdova commented Oct 1, 2024

cc @bharatkashyap if I am not mistaken there are some gifs usages in Toolpad too (I apologize if this is not the case :))

@oliviertassinari oliviertassinari merged commit 11214b0 into mui:master Oct 2, 2024
24 of 25 checks passed
@oliviertassinari oliviertassinari deleted the blog-fix-file-size branch October 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog performance scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants