Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Follow media asset guidelines #44374

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 10, 2024

Scale #43945 to all the pages in anticipation for us to fix:

I used the opportunity to fix a bunch of problems:

And to add the missing logic to to work with the blog too.

Preview: https://deploy-preview-44374--material-ui.netlify.app/blog/

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work blog labels Nov 10, 2024
@mui-bot
Copy link

mui-bot commented Nov 10, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5fb53ec

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Nov 11, 2024
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari merged commit 14983e5 into mui:master Nov 11, 2024
22 checks passed
@oliviertassinari oliviertassinari deleted the patch-medias branch November 11, 2024 16:29
@oliviertassinari
Copy link
Member Author

cc @alelthomas and @samuelsycamore for awareness as you are more likely to gravitate around new blog posts.

Until we solve those problems at the root with proper image loading logic (CDN, Next.js integration, etc.), following https://www.notion.so/mui-org/High-quality-media-5a1686758f4f4267989b67a1c2c270da should yield the best UX on the blog posts. No layout shifts, pixelated images, etc 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants