Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove IE 11 compat logic #12119

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[core] Remove IE 11 compat logic #12119

merged 1 commit into from
Feb 19, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 18, 2024 •
edited
Loading

Per mui/material-ui#40958 (comment), It's safe to say that IE 11 will be entirely gone from Material UI v6, so it makes sense for MUI X v7 too. This is simpler to reason with and a bit smaller in bundle size.

I saw this in #11965

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Feb 18, 2024
@mui-bot
Copy link

mui-bot commented Feb 18, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12119--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c4ac20b

flaviendelangle
flaviendelangle reviewed Feb 19, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also drop the legacy bundle which seems to be used for IE11?

      legacy: {
        plugins: [
          // IE11 support
          '@babel/plugin-transform-object-assign',
        ],
      },

@flaviendelangle flaviendelangle mentioned this pull request Feb 19, 2024
Merged
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 19, 2024 •
edited
Loading

Should we also drop the legacy bundle which seems to be used for IE11?

I guess so https://mui.com/material-ui/guides/minimizing-bundle-size/#legacy-bundle. This PR would only be a small step along the way.

@oliviertassinari oliviertassinari mentioned this pull request Feb 19, 2024
Closed
3 tasks
@oliviertassinari
Copy link
Member Author

Issue created #12141.

@oliviertassinari oliviertassinari merged commit 1e4c87b into mui:next Feb 19, 2024
17 checks passed
@oliviertassinari oliviertassinari deleted the remove-dead-logic-ie11 branch February 19, 2024 17:40
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@oliviertassinari @thomasmoon
[core] Remove IE 11 compat logic (mui#12119)
198c7ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @flaviendelangle