Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Fix clipboard paste not working with Caps Lock enabled #11965

Merged
merged 4 commits into from
Feb 7, 2024
Merged

[data grid] Fix clipboard paste not working with Caps Lock enabled #11965

merged 4 commits into from
Feb 7, 2024

Conversation

shaharyar-shamshi
Copy link
Contributor

Fixes #11790

@mui-bot
Copy link

mui-bot commented Feb 7, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-11965--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 836edf7

@shaharyar-shamshi
Copy link
Contributor Author

@romgrk I assume it needs to be merged only

@romgrk romgrk merged commit 221e84a into mui:next Feb 7, 2024
17 checks passed
@shaharyar-shamshi shaharyar-shamshi deleted the data-grid/hotfix/clipboardPaste branch February 7, 2024 05:38
@michelengelen michelengelen added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Clipboard Related to clipboard copy or paste functionalities labels Feb 7, 2024
@cherniavskii cherniavskii added the plan: Premium Impact at least one Premium user label Feb 7, 2024
@cherniavskii cherniavskii changed the title [data grid] Fix Unable to Paste Row Data in Data Grid with CAPS Lock Key Enabled [DataGridPremium] Fix Unable to Paste Row Data in Data Grid with CAPS Lock Key Enabled Feb 7, 2024
@cherniavskii cherniavskii added the CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 label Feb 7, 2024
@cherniavskii
Copy link
Member

@shaharyar-shamshi thank you for this pull request! Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

@shaharyar-shamshi
Copy link
Contributor Author

@shaharyar-shamshi thank you for this pull request! Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

Sure let me sign the CLA

@cherniavskii cherniavskii changed the title [DataGridPremium] Fix Unable to Paste Row Data in Data Grid with CAPS Lock Key Enabled [DataGridPremium] Fix clipboard paste not working with Caps Lock enabled Feb 9, 2024
@shaharyar-shamshi
Copy link
Contributor Author

@shaharyar-shamshi thank you for this pull request! Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

Sure let me sign the CLA

Done

@zannager
Copy link
Member

@shaharyar-shamshi can you please complete the step 3 - Forward the “form submission confirmation” email (check also your spam folder) to team-legal@mui.com to confirm your identity. Also, include the link to the pull request it corresponds to. Thanks.

@oliviertassinari oliviertassinari added CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 and removed CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Feb 18, 2024
@oliviertassinari
Copy link
Member

✅

We could have considered the changes CLA free, under the trivial clause as most of the changes were supervised https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0#ede845886e494cb4b802a67563152130

@oliviertassinari oliviertassinari changed the title [DataGridPremium] Fix clipboard paste not working with Caps Lock enabled [data grid] Fix clipboard paste not working with Caps Lock enabled Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Merged
Merged
Merged
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@shaharyar-shamshi @thomasmoon
[data grid] Fix Unable to Paste Row Data in Data Grid with CAPS Lock …
b859330 
…Key Enabled (mui#11965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! feature: Clipboard Related to clipboard copy or paste functionalities plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Unable to Paste Row Data in Data Grid with CAPS Lock Key Enabled
7 participants
@shaharyar-shamshi @mui-bot @cherniavskii @zannager @oliviertassinari @romgrk @michelengelen