[core] Fix shortcuts when Caps Lock enabled #12121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
keyboard-scale-11965
branch
from
0c2c19c
to
a69d0db
Compare
oliviertassinari
force-pushed
the
keyboard-scale-11965
branch
from
a69d0db
to
00329e3
Compare
| @@ -304,11 +304,13 @@ function defaultPasteResolver({ | |||
| }); | |||
| } | |||
|
|
|||
| const isPasteShortcut = (event: React.KeyboardEvent) => { | |||
There was a problem hiding this comment.
Revert that named function -> anonymous arrow function change. It goes against the style convention in the organization.
oliviertassinari
force-pushed
the
keyboard-scale-11965
branch
2 times, most recently
from
1f78961
to
732229e
Compare
oliviertassinari
force-pushed
the
keyboard-scale-11965
branch
from
732229e
to
3ad57b8
Compare
|
Deploy preview: https://deploy-preview-12121--material-ui-x.netlify.app/ |
romgrk
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO, if we close #11790, I think it should be after we fully fixed the issue. #11965 is a step, but there is more. Here is a quick PR to go more in depth:
toLowerCaseis missing in a good chunk of other cases