Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7.3.2 #12971

Merged
merged 16 commits into from
May 2, 2024
Merged

v7.3.2 #12971

merged 16 commits into from
May 2, 2024

Conversation

JCQuintas
Copy link
Member

No description provided.

@JCQuintas JCQuintas added the release We are shipping :D label May 2, 2024
@JCQuintas JCQuintas requested a review from a team May 2, 2024 10:13
@JCQuintas JCQuintas self-assigned this May 2, 2024
JCQuintas
JCQuintas commented May 2, 2024
View reviewed changes
CHANGELOG.md Outdated

### Tree View

#### `@mui/x-tree-view@7.3.2`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we bump when there are no changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately we've been releasing whatever lerna detects, that sometimes means that packages, which only received dependency bumps would also be picked up.
This decision has not been finalized yet, but we did release such packages with the last few releases.
Personally, I lean more towards not releasing what has not changed, but that's just my opinion with "hyper-optimisation" in mind. 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it for now as @michelengelen suggested. I don't have any preference, but would like to add our decision to the readme file so it is documented for the next new joiner 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it.
Totally agree that it should be documented once we land on a decision. 👌

@mui-bot
Copy link

mui-bot commented May 2, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12971--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 950ff4a

LukasTy
LukasTy reviewed May 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

### Tree View

#### `@mui/x-tree-view@7.3.2`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately we've been releasing whatever lerna detects, that sometimes means that packages, which only received dependency bumps would also be picked up.
This decision has not been finalized yet, but we did release such packages with the last few releases.
Personally, I lean more towards not releasing what has not changed, but that's just my opinion with "hyper-optimisation" in mind. 😆

CHANGELOG.md Outdated Show resolved Hide resolved
@JCQuintas @LukasTy
Update CHANGELOG.md
3cc7066 
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
MBilalShafi
MBilalShafi approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged a few PRs

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
JCQuintas and others added 3 commits May 2, 2024 13:37
@JCQuintas @MBilalShafi
Update CHANGELOG.md
a27ac58 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
178e2be 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
e3cafa7 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
MBilalShafi
MBilalShafi reviewed May 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
JCQuintas and others added 3 commits May 2, 2024 13:38
@JCQuintas @MBilalShafi
Update CHANGELOG.md
038683e 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
e548850 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
3d1def8 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
MBilalShafi
MBilalShafi reviewed May 2, 2024
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
MBilalShafi
MBilalShafi reviewed May 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
JCQuintas and others added 2 commits May 2, 2024 13:54
@JCQuintas @MBilalShafi
Update CHANGELOG.md
fce659c 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
8381cd3 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
JCQuintas and others added 3 commits May 2, 2024 14:04
@JCQuintas @MBilalShafi
Update CHANGELOG.md
054d023 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas @MBilalShafi
Update CHANGELOG.md
6fd4939 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
@JCQuintas
update gradiend id change msg
302726d
LukasTy
LukasTy approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍
LGTM! 🚀

noraleonte
noraleonte approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Congrats on your first release PR! 🍰

@JCQuintas @MBilalShafi
Update CHANGELOG.md
950ff4a 
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
michelengelen
michelengelen approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... :shipit:
Congrats on your first release PR! 🎉

@JCQuintas JCQuintas merged commit 75f63c3 into mui:master May 2, 2024
17 checks passed
@JCQuintas JCQuintas deleted the v7.3.2 branch May 2, 2024 14:36
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@JCQuintas @LukasTy
@MBilalShafi @DungTiger
v7.3.2 (mui#12971)
216647f 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@JCQuintas @LukasTy
@MBilalShafi @thomasmoon
v7.3.2 (mui#12971)
cbd66be 
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@noraleonte noraleonte noraleonte approved these changes

@michelengelen michelengelen michelengelen approved these changes

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

@romgrk romgrk Awaiting requested review from romgrk

@DanailH DanailH Awaiting requested review from DanailH

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@JCQuintas JCQuintas

Labels
release We are shipping :D
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JCQuintas @mui-bot @LukasTy @MBilalShafi @michelengelen @noraleonte