-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Add expansionTrigger
prop
#13533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
added
the
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
label
Jun 18, 2024
Deploy preview: https://deploy-preview-13533--material-ui-x.netlify.app/ Updated pages: |
noraleonte
commented
Jun 18, 2024
docs/data/tree-view/rich-tree-view/customization/IconExpansionTreeView.tsx
Show resolved
Hide resolved
docs/data/tree-view/rich-tree-view/customization/IconExpansionTreeView.js
Show resolved
Hide resolved
docs/data/tree-view/rich-tree-view/customization/IconExpansionTreeView.tsx
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/IconExpansionTreeView.js
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewExpansion/useTreeViewExpansion.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jun 19, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jun 19, 2024
flaviendelangle
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpick on the doc, the behavior looks great!
Thanks for taking care of it 🥳
noraleonte
commented
Jun 25, 2024
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
noraleonte
commented
Jun 25, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #13388
By default, the expansion of a tree item is triggered if the
content
is clicked. This PR introduces a prop to allow users to override this behavior, and limit the expansion toiconContainer