Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Cleanup monorepo and @mui/docs usage #13713

Merged
merged 11 commits into from
Jul 3, 2024
Merged

[code-infra] Cleanup monorepo and @mui/docs usage #13713

merged 11 commits into from
Jul 3, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 3, 2024

  • Cleanup remaining usages of imports that can be replaced with @mui/docs
  • Use @mui/docs from npm (as a dep) instead of aliasing monorepo

@LukasTy LukasTy added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Jul 3, 2024
@LukasTy LukasTy self-assigned this Jul 3, 2024
@LukasTy LukasTy changed the title [code-infra] Monorepo deps cleanup [code-infra] Cleanup monorepo and @mui/docs usage Jul 3, 2024
@mui-bot
Copy link

mui-bot commented Jul 3, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13713--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against c394899

@LukasTy LukasTy added the scope: docs-infra Specific to the docs-infra product label Jul 3, 2024
@LukasTy LukasTy mentioned this pull request Jul 3, 2024
Merged
@LukasTy
Copy link
Member Author

LukasTy commented Jul 3, 2024

@mui/code-infra @mui/docs-infra Do you know why there is this problem of href initially missing ending / and resulting in i.e. /x/react-data-grid/getting-started#installation on initial load, but /x/react-data-grid/getting-started/#installation after subsequent navigation (hydration).

@Janpot
Copy link
Member

Janpot commented Jul 3, 2024

I'm not 100% sure why, but we had to transpile @mui/docs to fix it https://github.com/mui/mui-toolpad/pull/3402/files

@LukasTy
Copy link
Member Author

LukasTy commented Jul 3, 2024

I'm not 100% sure why, but we had to transpile @mui/docs to fix it https://github.com/mui/mui-toolpad/pull/3402/files

Thank you for this confirmation. 🙏
Seems like a bit strange behavior that might be worth investigation, but let's not blow the scope. 🤔 🙈

@LukasTy LukasTy requested review from a team July 3, 2024 10:28
@LukasTy LukasTy mentioned this pull request Jul 3, 2024
Merged
LukasTy
LukasTy commented Jul 3, 2024
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@LukasTy
Revert @mui/docs aliasing removal—types
c394899 
Signed-off-by: Lukas <llukas.tyla@gmail.com>
@LukasTy LukasTy merged commit b5a389a into mui:master Jul 3, 2024
17 checks passed
@LukasTy LukasTy deleted the monorepo-deps-cleanup branch July 3, 2024 14:16
@LukasTy LukasTy mentioned this pull request Jul 4, 2024
Closed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@LukasTy @DungTiger
[code-infra] Cleanup monorepo and @mui/docs usage (mui#13713)
78e48cf 
Signed-off-by: Lukas <llukas.tyla@gmail.com>
This was referenced Jul 27, 2024
Open
Open
@arnfinn arnfinn mentioned this pull request Aug 8, 2024
Closed
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@LukasTy @thomasmoon
[code-infra] Cleanup monorepo and @mui/docs usage (mui#13713)
ded2cda 
Signed-off-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@LukasTy LukasTy

Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LukasTy @mui-bot @Janpot @alexfauquette