Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Remove usage of HighlightedCodeWithTabs through monorepo alias #13723

Closed
wants to merge 4 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 4, 2024

Chipping away at removing all usage of the monorepo docs alias

Blocked on mui/material-ui#42841

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Jul 4, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 4, 2024

Sorry, I already did it in #13713 🙈

@Janpot
Copy link
Member Author

Janpot commented Jul 4, 2024

Oh great! Note to myself, don't forget to rebase master before you start 😄

@Janpot Janpot closed this Jul 4, 2024
@Janpot Janpot reopened this Jul 4, 2024
@mui-bot
Copy link

mui-bot commented Jul 4, 2024

Deploy preview: https://deploy-preview-13723--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4401740

@Janpot
Copy link
Member Author

Janpot commented Jul 4, 2024

Actually, I also snuck in the import to HighLightedCodeWithTabs in this PR in anticipation to mui/material-ui#42841, may as well keep it

@Janpot Janpot changed the title [code-infra] Remove usage of ComponentLinkHeader through monorepo alias [code-infra] Remove usage of HighlightedCodeWithTabs through monorepo alias Jul 4, 2024
@LukasTy
Copy link
Member

LukasTy commented Jul 4, 2024

Actually, I also snuck in the import to HighLightedCodeWithTabs in this PR in anticipation to mui/material-ui#42841, may as well keep it

Yeah, thanks, we can do that after the monorepo is bumped. 👍

Copy link

github-actions bot commented Jul 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants