Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Support for @mui packages #2571

Merged
merged 6 commits into from
Sep 9, 2021
Merged

[core] Support for @mui packages #2571

merged 6 commits into from
Sep 9, 2021

Conversation

m4theushw
Copy link
Member

Fixes #2527

m4theushw
m4theushw commented Sep 9, 2021
View reviewed changes
packages/grid/x-grid-data-generator/src/renderer/renderEditProgress.tsx
@@ -89,7 +90,7 @@ function EditProgress(props: GridRenderEditCellParams) {

const handleRef: SliderProps['ref'] = (element) => {
if (element) {
element.querySelector<HTMLElement>('[role="slider"]')!.focus();
element.querySelector<HTMLElement>('[type="range"]')!.focus();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #2556

@m4theushw m4theushw added the core Infrastructure work going on behind the scenes label Sep 9, 2021
m4theushw
m4theushw commented Sep 9, 2021
View reviewed changes
docs/scripts/formattedTSDemos.js
const babelConfig = {
presets: ['@babel/preset-typescript'],
plugins: [unwrap],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the core, this plugin is not used:

https://github.com/mui-org/material-ui/blob/1b563a153f5b2736f79a3f45573e2e2b66ba0a9a/docs/scripts/formattedTSDemos.js#L26

@flaviendelangle
Copy link
Member

image

https://deploy-preview-2571--material-ui-x.netlify.app/storybook/?path=/story/x-grid-tests-pagination--page-2-prop-snap

I can't reproduce the snapshot buggy behavior on your preview

The other snapshot diffs seems logical to me

@m4theushw m4theushw mentioned this pull request Sep 9, 2021
Closed
2 tasks
@flaviendelangle flaviendelangle mentioned this pull request Sep 9, 2021
Merged
@m4theushw
Copy link
Member Author

@flaviendelangle About the buggy snapshot. The test environment was still using the old @material-ui/core. There're only 10 differences now, which are because of the new palette.

@m4theushw m4theushw mentioned this pull request Sep 9, 2021
Closed
10 tasks
@m4theushw m4theushw merged commit ee94162 into mui:next Sep 9, 2021
@m4theushw m4theushw deleted the support-mui-packages branch September 9, 2021 18:35
@m4theushw m4theushw mentioned this pull request Sep 13, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@DanailH DanailH Awaiting requested review from DanailH

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] The DataGrid is not compatible with the new package name of the core repository
2 participants
@m4theushw @flaviendelangle