Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove v4 conditional code #2575

Merged
merged 10 commits into from
Sep 30, 2021
Merged

[core] Remove v4 conditional code #2575

merged 10 commits into from
Sep 30, 2021

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 9, 2021 •
edited by oliviertassinari
Loading

I wait for #2571 before doing those who are more than just remove some branches (for instance replace the muiStyleAlpha function by a direct call to alpha from the core

Preview: https://deploy-preview-2575--material-ui-x.netlify.app/components/data-grid/

@flaviendelangle flaviendelangle self-assigned this Sep 9, 2021
@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes v5.x component: data grid This is the name of the generic UI component, not the React module! labels Sep 9, 2021
@flaviendelangle flaviendelangle marked this pull request as draft September 9, 2021 13:10
@flaviendelangle flaviendelangle marked this pull request as ready for review September 9, 2021 14:50
@m4theushw m4theushw mentioned this pull request Sep 9, 2021
Closed
10 tasks
@flaviendelangle flaviendelangle added this to the Sprint 22 milestone Sep 14, 2021
oliviertassinari
oliviertassinari reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's going in the right direction.

@flaviendelangle
Copy link
Member Author

@oliviertassinari it's always a pleasure to remove this kind of temporary code

@flaviendelangle
Copy link
Member Author

Fixing this comment https://github.com/mui-org/material-ui-x/blob/next/packages/grid/_modules_/grid/components/columnSelection/GridHeaderCheckbox.tsx#L51 causes the related test to fail

I'll check and remove the comment if the v5 still needs the || isIndeterminate

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Sep 24, 2021
Closed
@flaviendelangle
Copy link
Member Author

I think we can move on without #2575 (comment) and fix the more complex one later

@flaviendelangle flaviendelangle merged commit f7fbc7d into mui:next Sep 30, 2021
@flaviendelangle flaviendelangle deleted the drop-v4 branch September 30, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@DanailH DanailH Awaiting requested review from DanailH

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes v5.x
Projects
None yet
Milestone
v5 stable version
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @oliviertassinari @m4theushw