[test] Run the karma tests in browserstack #316
Conversation
|
@dtassone The tests are run in:
However, we have a couple of issues with these targets (e.g. What's the minimum browsers' version we aim to support? :). It resonates with mui/material-ui#15496 from @eps1lon. |
oliviertassinari
force-pushed
the
test-browser-stack
branch
2 times, most recently
from
e7fce10 to
33eb492
Compare
| # # Default build command. | ||
| # command = "yarn docs:build && yarn docs:export && yarn storybook:build && yarn storybook:export && yarn demo:build && yarn demo:export" | ||
|
|
||
| [build.environment] |
There was a problem hiding this comment.
restored so we keep the version definition (help make sure it works in the lowest target we support)
| edge >= 83 | ||
| firefox >= 77 | ||
| chrome >= 83 | ||
| safari >= 11 | ||
| node 10.0 |
There was a problem hiding this comment.
It looks like another advantage of not using TypeScipt to build the source but Babel. They don't seem to support browser target microsoft/TypeScript#19183.
I'm definitely going to start with this the next week. Might not be the final target before release but it'll set up the final bundle structure and show in what direction the final bundle size goes. |
oliviertassinari
force-pushed
the
test-browser-stack
branch
from
33eb492 to
4639be0
Compare
|
The list of browsers can be queried at https://www.browserstack.com/docs/automate/api-reference/selenium/browser#get-browser-list. |
Cross-browser compatibility. We were missing the BrowserStack credentials in CircleCI.