Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run the karma tests in browserstack #316

Merged
merged 4 commits into from
Sep 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .browserslistrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
edge >= 83
firefox >= 77
chrome >= 83
safari >= 11
node 10.0
Comment on lines +1 to +5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like another advantage of not using TypeScipt to build the source but Babel. They don't seem to support browser target microsoft/TypeScript#19183.

12 changes: 0 additions & 12 deletions ignore_netlify.toml

This file was deleted.

12 changes: 12 additions & 0 deletions netlify.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# [build]
# # Directory (relative to root of your repo) that contains the deploy-ready
# # HTML files and assets generated by the build. If a base directory has
# # been specified, include it in the publish directory path.
# publish = "docs/export/"

# # Default build command.
# command = "yarn docs:build && yarn docs:export && yarn storybook:build && yarn storybook:export && yarn demo:build && yarn demo:export"

[build.environment]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored so we keep the version definition (help make sure it works in the lowest target we support)

NODE_VERSION = "10"
NODE_OPTIONS = "--max_old_space_size=4096"
2 changes: 1 addition & 1 deletion packages/grid/data-grid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@
],
"gitHead": "f1d56176bb6308bb55c69f5c2fd5593c4e4faebc",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/grid/x-grid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
],
"gitHead": "f1d56176bb6308bb55c69f5c2fd5593c4e4faebc",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/x-grid-data-generator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,6 @@
],
"gitHead": "f1d56176bb6308bb55c69f5c2fd5593c4e4faebc",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/x-license/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@
],
"gitHead": "f1d56176bb6308bb55c69f5c2fd5593c4e4faebc",
"engines": {
"node": ">=8.0.0"
"node": ">=10.0.0"
}
}
20 changes: 10 additions & 10 deletions test/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const webpack = require('webpack');
const browserStack = {
username: process.env.BROWSERSTACK_USERNAME,
accessKey: process.env.BROWSERSTACK_ACCESS_KEY,
build: `material-ui-${new Date().toISOString()}`,
build: `material-ui-x-${new Date().toISOString()}`,
};

process.env.CHROME_BIN = require('puppeteer').executablePath();
Expand Down Expand Up @@ -123,29 +123,29 @@ module.exports = function setKarmaConfig(config) {
base: 'BrowserStack',
os: 'OS X',
os_version: 'Sierra',
browser: 'Chrome',
browser_version: '49.0',
browser: 'chrome',
browser_version: '83.0',
},
BrowserStack_Firefox: {
base: 'BrowserStack',
os: 'Windows',
os_version: '10',
browser: 'Firefox',
browser_version: '52.0',
browser: 'firefox',
browser_version: '78.0',
},
BrowserStack_Safari: {
base: 'BrowserStack',
os: 'OS X',
os_version: 'Sierra',
browser: 'Safari',
browser_version: '10.1',
os_version: 'High Sierra',
browser: 'safari',
browser_version: '11.1',
},
BrowserStack_Edge: {
base: 'BrowserStack',
os: 'Windows',
os_version: '10',
browser: 'Edge',
browser_version: '14.0',
browser: 'edge',
browser_version: '83.0',
},
},
};
Expand Down