-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Implement Aggregation (not publicly released) #4208
Conversation
These are the results for the performance tests:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Following a discussion with @oliviertassinari That way, we can merge the feature in its current shape to ease the review of the row pinning when ready. |
c613d74
to
9cbee1f
Compare
9cbee1f
to
cdfc496
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Seems like the label could be there, but truncate when resizing the column? In Figma, I had some exploration around the way the labels are displayed when sorting, filtering, etc is applied as well. There could be a benefit of a tidier header if we condense the visual indicators of applied actions, but we lose the clarity at a glance. |
We are looking to use this feature. When will this be publicly available? |
@kittyvandergijp after #5592 is merged, likely in the next release |
Closes #213
Doc preview
Extracted PRs
#4216
#4359
#4378
#4896
Works
Model
Rows
Columns
Rendering
valueFormatter
on the aggregation functionAdd one select per available position in the column menu
Aggregation in the row flow chart
The chart below shows that the aggregation is triggered between the sorting and the filtering.