[core] Use a pipe processor for GridPreferencePanel children
#4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
flaviendelangle
changed the title
GridPreferencePanel children
|
These are the results for the performance tests:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Comment on lines
25
to
32
| {...rootProps.componentsProps?.basePopper} | ||
| > | ||
| {!rootProps.disableColumnSelector && isColumnsTabOpen && ( | ||
| <rootProps.components.ColumnsPanel {...rootProps.componentsProps?.columnsPanel} /> | ||
| )} | ||
|
|
||
| {!rootProps.disableColumnFilter && isFiltersTabOpen && ( | ||
| <rootProps.components.FilterPanel {...rootProps.componentsProps?.filterPanel} /> | ||
| {apiRef.current.unstable_applyPreProcessors( | ||
| 'preferencePanel', | ||
| null, | ||
| preferencePanelState.openedPanelValue ?? GridPreferencePanelsValue.filters, | ||
| )} | ||
| </rootProps.components.Panel> |
There was a problem hiding this comment.
That's a bit weird to see apiRef.current.unstable_applyPreProcessors called inside the rendering
Could be more readable as follow, but not 100% sure it's the same
const panelContent = apiRef.current.unstable_applyPreProcessors(...);
...
<rootProps.components.Panel ...>
{panelContent}
</rootProps.components.Panel>There was a problem hiding this comment.
It is the same yes
Done
alexfauquette
approved these changes
Mar 21, 2022
I plan to rename all this pre-processing code to |
m4theushw
approved these changes
Mar 21, 2022
10 tasks
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4208
If we want to add a preference panel from a pro / premium feature, we are currently stuck.
Maybe we need to change the whole approach of the preference panel at some point, but this PRs should not introduce any breaking change.