[core] Remove rowsCache from state

[m4theushw]

Fixes the following TODO by removing the cache from the state and moving it to apiRef. In #3896 I added it to the state because was the simplest thing to do.

mui-x/packages/grid/x-data-grid/src/hooks/features/rows/useGridRows.ts

Line 127 in b2b9420

rowsCache, // TODO remove from state

I also converted the variables used to track the timeout into refs.

Instead of using apiRef, another alternative could be the following:

diff --git a/packages/grid/x-data-grid/src/DataGrid/useDataGridComponent.tsx b/packages/grid/x-data-grid/src/DataGrid/useDataGridComponent.tsx
index b617e664b..88acba309 100644
--- a/packages/grid/x-data-grid/src/DataGrid/useDataGridComponent.tsx
+++ b/packages/grid/x-data-grid/src/DataGrid/useDataGridComponent.tsx
@@ -50,6 +50,7 @@ import { useGridColumnSpanning } from '../hooks/features/columns/useGridColumnSp
 
 export const useDataGridComponent = (props: DataGridProcessedProps) => {
   const apiRef = useGridInitialization<GridApiCommunity>(undefined, props);
+  const rowsCache = React.useRef();
 
   /**
    * Register all pre-processors called during state initialization here.
@@ -62,7 +63,7 @@ export const useDataGridComponent = (props: DataGridProcessedProps) => {
    */
   useGridInitializeState(selectionStateInitializer, apiRef, props);
   useGridInitializeState(columnsStateInitializer, apiRef, props);
-  useGridInitializeState(rowsStateInitializer, apiRef, props);
+  useGridInitializeState(rowsStateInitializer, apiRef, props, { rowsCache });
   useGridInitializeState(
     props.experimentalFeatures?.newEditingApi
       ? editingStateInitializer_new

[mui-bot]

These are the results for the performance tests:

Test case	Unit	Min	Max	Median	Mean	σ
Filter 100k rows	ms	258.4	505.6	434.8	391.18	109.945
Sort 100k rows	ms	496.6	852.2	708.2	687.56	127.817
Select 100k rows	ms	128.3	231.2	151.5	165.36	37.954
Deselect 100k rows	ms	100.9	279.6	184.3	187.06	57.082

Generated by 🚫 dangerJS against 37dbfcc

[flaviendelangle]

If we keep it in the apiRef, what do you think about doing apiRef.current.caches.rows ?
Or apiRef.current.unstable_caches.rows if we want to keep it private for now.

I would like to move unstable_sanitizedModelOnLastRowTreeCreation out of the state (same for the equivalent of the Aggregation)
Maybe it's worth scoping it instead of doing it on the root (same for the DOM refs btw)

For the alternative you gave in the PR description, it don't know how we could adapt it in the future to allow custom plugins with there own cache without touching the useDataGridXXXComponent hook.
But as long as the caches system is private, we can rewrite it to be compatible when we know what the plugins will actually look like

[m4theushw]

I went with unstable_caches. I hope that theme augmentation works to enrich the cache interface to allow custom plugins to have their own cache.

[flaviendelangle]

It should work perfectly

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[flaviendelangle]

I think we can go on with this one, #4208 will need a very similar implementation (I did a custom one for now to have something that works)