[DataGrid] Restore regression test #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
test
component: data grid
dtassone
approved these changes
Oct 26, 2020
|
There's no safe API that doesn't lead to swallowing of error messages as far as I can tell. This is just how thrown errors work in React. I wouldn't recommend ignoring errors anyway. Tests should be optimized for descriptiveness and illustrate what a user would see. Ignoring the console.error calls would not tell you about the actual DX. This is less of an issue in React 17 where the double logs from StrictMode are hidden by default. |
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was skipped in #412.
@eps1lon In this case, we are only interested in testing that the error boundary reports the problem. It's the same as https://github.com/mui-org/material-ui/blob/db3581f75f88905e2791560c0527010f98a92a9b/packages/material-ui/src/Select/Select.test.js#L849.
Is there a way to ignore the console.error calls? I guess @dtassone has skipped the test because it wasn't obvious, at first sight, what was the solution. But anyway, it's probably an edge case, we can move forward like this :)