Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Restore regression test #503

Merged
merged 1 commit into from
Oct 26, 2020
Merged

[DataGrid] Restore regression test #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/grid/data-grid/src/DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,7 @@ describe('<DataGrid />', () => {
}).toErrorDev('Material-UI: `<DataGrid pagination={false} />` is not a valid prop.');
});

// eslint-disable-next-line mocha/no-skipped-tests
xit('should throw if the rows has no id', function test() {
it('should throw if the rows has no id', function test() {
// TODO is this fixed?
if (!/jsdom/.test(window.navigator.userAgent)) {
// can't catch render errors in the browser for unknown reason
Expand All @@ -166,7 +165,7 @@ describe('<DataGrid />', () => {
}).toErrorDev([
'The data grid component requires all rows to have a unique id property',
'The above error occurred in the <ForwardRef(GridComponent)> component',
'The above error occurred in the <ForwardRef(DataGrid)> component',
'The above error occurred in the <ForwardRef(GridComponent)> component',
]);
expect((errorRef.current as any).errors).to.have.length(1);
expect((errorRef.current as any).errors[0].toString()).to.include(
Expand Down