[DataGrid] Improve filters

[dtassone]

Fix some of the ticks of #633

[oliviertassinari]

I'm not sure if I was supposed to start reviewing it, so I have left a few quick feedback :)

[oliviertassinari]

We are moving in the right direction :)

• Regarding item 6. The close transition is now missing, but it's better than having a jump.
• I have also noticed that the scroll is broken when opening the column menu. This is because of the autofocus on the input. There might be something wrong with the popper logic. A workaround is to delay the focus in an effect.

[oliviertassinari]

A point we have started to discuss with @DanailH. I think that we should replace if (process.env.NODE_ENV === 'production') for the feature toggle, to a if (process.env.ENABLE_EXPERIMENTAL) flag. The issue with NODE_ENV is that it's 'production' in the Netlify preview. We can't easily review PRs, it forces us to check out each time. I'm working on it.

[dtassone]

We are moving in the right direction :)

• Regarding item 6. The close transition is now missing.
• I have also noticed that the scroll is broken when opening the column menu

I'm not sure what you mean by the scroll.

can you try again the 6 and let me know if it's ok now :)

[oliviertassinari]

I'm not sure what you mean by the scroll.

Open the documentation, you will see, one negative point for storybook's isolation :p. I'm working on #635 (comment) so we can share a link. My env is broken so I can't share video yet.

[oliviertassinari]

[dtassone]

this is caused by the autoFocus prop on the TextField, maybe a bug in core?

I refactored and fixed the issue

[oliviertassinari]

this is caused by the autoFocus prop on the TextField, maybe a bug in core?

autoFocus is a native attribute, actually discouraged for a11y, but that doesn't really matter here. Yes, it could be an issue with the Popper component.