Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Introduce a feature toggle #637

Merged
merged 10 commits into from
Nov 26, 2020
Merged

[core] Introduce a feature toggle #637

merged 10 commits into from
Nov 26, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 24, 2020 •
edited
Loading

The problem was raised in #635 (comment).

A guide to feature toggling.

The feature toggle is:

  • independent from the NODE_ENV.
  • isn't pruning code in production, as the objective is to eventually ship the code.
  • doesn't allow to cherry-pick which feature to enable, it's all or nothing and on purpose.

By default, the experimental features are only enabled in:

  • the local environment
  • the pull request previews

Reviewers can force the value with the local storage and the EXPERIMENTAL_ENABLED key:

  • 'true' => force it to be enabled
  • 'false' => force it to be disabled

Developers (users) aren't a targeted audience for the feature flag, if we want them to try experimental features, they should have a prop and be documented.

@oliviertassinari oliviertassinari marked this pull request as draft November 24, 2020 18:43
@oliviertassinari oliviertassinari marked this pull request as ready for review November 24, 2020 19:14
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 24, 2020 •
edited
Loading

It seems to work:

It also surfaces a new issue: we can't open the filter in the documentation, feedback added in #633 (comment).

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [core] Allow to deploy experimental feature in Netlify [core] Enable experimental feature everywhere expect production Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [core] Enable experimental feature everywhere expect production [core] Enable experimental features everywhere expect production Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [core] Enable experimental features everywhere expect production [core] Enable experimental features everywhere except production Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [core] Enable experimental features everywhere except production [core] Introduce feature a feature toggle Nov 26, 2020
@oliviertassinari oliviertassinari changed the title [core] Introduce feature a feature toggle [core] Introduce a feature toggle Nov 26, 2020
@oliviertassinari oliviertassinari merged commit 7094823 into mui:master Nov 26, 2020
@oliviertassinari oliviertassinari deleted the feature-flag- branch November 26, 2020 18:53
@oliviertassinari oliviertassinari mentioned this pull request Dec 3, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

@dtassone dtassone dtassone approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @dtassone @DanailH