Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Rename ClockPicker into TimeClock #6851

Merged
merged 7 commits into from
Nov 15, 2022
Merged

[pickers] Rename ClockPicker into TimeClock #6851

merged 7 commits into from
Nov 15, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 15, 2022 •
edited by LukasTy
Loading

Closes #6709

Changelog

Breaking changes

The ClockPicker view component has been renamed TimeClock to better fit its usage:

-<ClockPicker {...props} />
+<TimeClock {...props} />

Component name in the theme has changed as well:

-MuiClockPicker: {
+MuiTimeClock: {

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Nov 15, 2022
@flaviendelangle flaviendelangle self-assigned this Nov 15, 2022
@flaviendelangle flaviendelangle changed the title [pickers] Rename ClockPicker TimeClock [pickers] Rename ClockPicker into TimeClock Nov 15, 2022
@mui-bot
Copy link

mui-bot commented Nov 15, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-6851--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 598.5 988.3 608.6 726.32 157.627
Sort 100k rows ms 575.8 1,023.4 779.6 816.2 146.842
Select 100k rows ms 199.2 296.6 222.4 244.18 41.484
Deselect 100k rows ms 147.1 292.3 178.3 204.54 52.705

Generated by 🚫 dangerJS against 2c69578

@flaviendelangle flaviendelangle marked this pull request as ready for review November 15, 2022 09:19
@flaviendelangle @alexfauquette
Update docs/data/migration/migration-pickers-v5/migration-pickers-v5.md
2c69578 
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle flaviendelangle merged commit 32f3a7f into mui:next Nov 15, 2022
@flaviendelangle flaviendelangle deleted the time-clock branch November 15, 2022 11:17
@flaviendelangle flaviendelangle mentioned this pull request Nov 15, 2022
Merged
@flaviendelangle flaviendelangle mentioned this pull request Dec 20, 2022
Merged
@LukasTy LukasTy mentioned this pull request Dec 20, 2022
Closed
19 tasks
@LukasTy LukasTy added the v6.x label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@LukasTy LukasTy Awaiting requested review from LukasTy

Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Rename ClockPicker into TimeClock
4 participants
@flaviendelangle @mui-bot @alexfauquette @LukasTy