Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Rename CalendarPickerView, ClockPickerView and CalendarOrClockPickerView #6855

Merged
merged 2 commits into from
Nov 17, 2022
Merged

[pickers] Rename CalendarPickerView, ClockPickerView and CalendarOrClockPickerView #6855

merged 2 commits into from
Nov 17, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 15, 2022 •
edited
Loading

Follow up on #6389 and #6851

I am not documenting the breaking change on inputModeToggleButtonAriaLabel because this translation method will go away with the removal of the legacy pickers

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Nov 15, 2022
@flaviendelangle flaviendelangle self-assigned this Nov 15, 2022
@mui-bot
Copy link

mui-bot commented Nov 15, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-6855--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 609 960.8 661.9 717.78 130.152
Sort 100k rows ms 561.3 1,012.4 692.1 829.74 173.994
Select 100k rows ms 155.5 272.3 208.1 210.14 37.154
Deselect 100k rows ms 128.8 243.1 186 184.54 37.181

Generated by 🚫 dangerJS against 2859957

@flaviendelangle flaviendelangle marked this pull request as ready for review November 16, 2022 10:11
LukasTy
LukasTy approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@flaviendelangle flaviendelangle merged commit 21afe09 into mui:next Nov 17, 2022
@flaviendelangle flaviendelangle deleted the rename-view-types branch November 17, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @LukasTy