Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Chinese (zh-CN) and Chinese(traditional) (zh-TW) locales #9999

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

MyNameIsTakenOMG
Copy link
Contributor

This PR adds the missing translation for the zhCN and zhTW locales requested in #3211

@mui-bot
Copy link

mui-bot commented Aug 11, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9999--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 319.1 511.6 414.5 406.94 77.371
Sort 100k rows ms 762.4 1,456.8 1,441 1,252.2 254.802
Select 100k rows ms 636.6 827 719.6 734.56 72.543
Deselect 100k rows ms 95.8 277.4 226.3 195.16 62.184

Generated by 🚫 dangerJS against 3e6b31c

@zannager zannager added the l10n localization label Aug 11, 2023
@oliviertassinari oliviertassinari merged commit f074f27 into mui:master Aug 11, 2023
17 of 18 checks passed
@oliviertassinari
Copy link
Member

@MyNameIsTakenOMG Thanks!

@MyNameIsTakenOMG
Copy link
Contributor Author

@MyNameIsTakenOMG Thanks!

My pleasure to make a contribution to the community☺👍

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Aug 12, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 12, 2023

@DanailH This makes me think of an automation opportunity, we could automatically apply GitHub labels based on which file are changed in Core, X. https://www.notion.so/mui-org/GitHub-community-issues-PRs-Tier-1-12a84fdf50e44595afc55343dac00fca?pvs=4#7aff02318a2d47e8b180f14c6cfc55b8, an idea for Michel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants