new object explorer implementation based on react-arborist #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-1271.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cdhvklun6mpr3pb3h7l0. |
|
Your Render PR Server URL is https://toolpad-pr-1271.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cdl99mhgp3jrau9irj00. |
Janpot
changed the title
github-actions
bot
added
the
PR: out-of-date
Janpot
changed the title
oliviertassinari
requested a deployment
to
treeview-object-explorer - toolpad-db PR #1271
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
temporarily deployed
to
treeview-object-explorer - toolpad PR #1271
Render
Destroyed
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
requested a deployment
to
treeview-object-explorer - toolpad-db PR #1271
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
temporarily deployed
to
treeview-object-explorer - toolpad PR #1271
Render
Destroyed
github-actions
bot
added
the
PR: out-of-date
|
Hey @Janpot, thanks for this PR. Did you encounter some problems that prevent from merging it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use react-arborist for an object explorer. Currently it looks like
For the global scope explorer, to be able to size it correctly, and have virtualization, we'd need to present it as one tree, all categories as tree nodes included. This is currently stuck on dynamic row heights, to make give the headers their padding.