Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group scope variables by function in global scope explorer #1464

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 16, 2022

Working on getting meta info of page state from the runtime into the editor. This first iteration improves the global scope editor by grouping related items.

The crux of this implementation is bringing information about scope variables from the runtime into the editor.

One of the shortcomings is the object explorer which is really hitting its limits (e.g. can't remove that object preview. It's too limited to customize). Can't make it look much better than this. Will advance #1271 to improve the object explorer.

Screenshot 2022-12-21 at 14 37 09

Closes #1262

@oliviertassinari oliviertassinari requested a deployment to scope-meta - toolpad-db PR #1464 December 16, 2022 16:54 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to scope-meta - toolpad PR #1464 December 16, 2022 16:54 — with Render Destroyed
@oliviertassinari oliviertassinari requested a deployment to scope-meta - toolpad-db PR #1464 December 21, 2022 09:05 — with Render Abandoned
@Janpot Janpot changed the title Base bindingeditor on globalScopeMeta only Group scope variables by function in global scope explorer Dec 21, 2022
@Janpot Janpot marked this pull request as ready for review December 21, 2022 13:59
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@oliviertassinari oliviertassinari temporarily deployed to scope-meta - toolpad PR #1464 December 21, 2022 21:37 — with Render Destroyed
@Janpot Janpot merged commit 2963896 into master Dec 22, 2022
@Janpot Janpot deleted the scope-meta branch December 22, 2022 06:37
@prakhargupta1
Copy link
Member

Just came across this change, looks much better now!

Screenshot 2022-12-22 at 12 57 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp bindings scope explorer UI
3 participants