Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jest tests for create-toolpad-app #1965

Merged
merged 28 commits into from
May 11, 2023
Merged

Add jest tests for create-toolpad-app #1965

merged 28 commits into from
May 11, 2023

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap added the core Infrastructure work going on behind the scenes label May 3, 2023
@bharatkashyap bharatkashyap requested a review from Janpot May 4, 2023 04:40
@Janpot
Copy link
Member

Janpot commented May 4, 2023

Have you seen the test output? https://app.circleci.com/pipelines/github/mui/mui-toolpad/7236/workflows/992b6458-36d0-496e-b685-e7297008af48/jobs/31467/parallel-runs/0/steps/0-113

To avoid async issues, avoid using callbacks and done. Best to use promises all the way. An async function that works with callbacks can easily be converted to a promise returning one

@Janpot
Copy link
Member

Janpot commented May 4, 2023

I've pushed a commit proposing an updated setup that may be easier to work with

@Janpot Janpot mentioned this pull request May 4, 2023
Merged
@bharatkashyap bharatkashyap requested a review from Janpot May 9, 2023 07:22
Janpot
Janpot reviewed May 9, 2023
View reviewed changes
packages/create-toolpad-app/tests/index.spec.ts
}),
}),
);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't you going to try running the app in this test as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm currently on that (also adding the no-install option to make running this test quicker)

@bharatkashyap bharatkashyap merged commit 4c34dd5 into mui:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test for create-toolpad-app
2 participants
@bharatkashyap @Janpot