-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix console.error being called in tests #1966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
May 5, 2023
github-actions
bot
added
PR: out-of-date
The pull request has merge conflicts and can't be merged
and removed
PR: out-of-date
The pull request has merge conflicts and can't be merged
labels
May 5, 2023
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
May 7, 2023
import ToolpadApp from './ToolpadApp'; | ||
import * as appDom from '../appDom'; | ||
import createRuntimeState from '../createRuntimeState'; | ||
import { bridge } from '../canvas/ToolpadBridge'; | ||
import { BridgeContext } from '../canvas/BridgeContext'; | ||
import loadComponents from './loadDomComponents'; | ||
|
||
failOnConsole(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to set this globally for any spec file?
This library seems to recommend using the file for setupFilesAfterEnv
for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were printing
But still passing
Noticed while working on #1965
I suspect this started happening since adding the Form component.
Related thread: https://github.com/orgs/react-hook-form/discussions/4232