format IDE code #2674
format IDE code #2674
Conversation
| let newValue = input; | ||
|
|
||
| if ((input as JsExpressionAttrValue)?.$$jsExpression) { | ||
| const jsExpression = await tryFormatExpression( | ||
| (input as JsExpressionAttrValue).$$jsExpression, | ||
| data!, |
There was a problem hiding this comment.
If the backend call to getPrettierConfig fails, or is still loading, data will be undefined. So using ! is not the right solution as that is only reserved for when data is guaranteed to be defined by the programmer.
Instead, show a warning to the user that explains that the prettier config couldn't be loaded and therefore the code won't be formatted when saving.
There was a problem hiding this comment.
If the backend call to
getPrettierConfigfails, or is still loading,datawill beundefined. So using!is not the right solution as that is only reserved for whendatais guaranteed to be defined by the programmer.Instead, show a warning to the user that explains that the prettier config couldn't be loaded and therefore the code won't be formatted when saving.
what's type of warning for user?
such as https://mui.com/material-ui/react-alert/?
There was a problem hiding this comment.
is there component that i can directly invoke ?
There was a problem hiding this comment.
An Alert could work. I'd have to see what it looks like. For me I think it's important it's inline, close enough to the save button (i.e. no popup)
There was a problem hiding this comment.
how about this ?
There was a problem hiding this comment.
this error only happens without a network I think
There could be a problem while prettier tries to access the file system, or a bug in our code, or in prettier, or our bundler could have transformed the code wrong, or it could be running on an incompatible node.js runtime that we're unaware about, a solar storm flipping a bit,... anything really 🙂
There was a problem hiding this comment.
There could be a problem while prettier tries to access the file system, or a bug in our code, or in prettier, or our bundler could have transformed the code wrong, or it could be running on an incompatible node.js runtime that we're unaware about, a solar storm flipping a bit,... anything really
I see.
do these errors need to be passed to front-end, if back-end occurs error ?
There was a problem hiding this comment.
@Janpot
please make a final check.
There was a problem hiding this comment.
@JerryWu1234 useQuery is a wrapper around react-query. Next to the data property it will return an error property.
There was a problem hiding this comment.
nice point out.
before I thought we need to add a try catch and then pass to front end. lol
I will do it late
…Wu1234/mui-toolpad into format_front_end_code_2585
#2585