-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format IDE code #2674
Merged
Merged
format IDE code #2674
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
df36181
fix
21bdcbc
delete code
edbfbe2
Merge branch 'master' into format_front_end_code_2585
JerryWu1234 5b393f5
text
84f6819
Merge branch 'master' into format_front_end_code_2585
JerryWu1234 bd25f0f
add tips for error
9b88c1d
fix
3aa56bc
Merge branch 'master' into format_front_end_code_2585
JerryWu1234 94d9205
fix
764955f
Merge branch 'format_front_end_code_2585' of https://github.com/Jerry…
adae272
Merge branch 'master' into format_front_end_code_2585
JerryWu1234 77e40e8
Merge branch 'master' into format_front_end_code_2585
JerryWu1234 1f33068
error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the backend call to
getPrettierConfig
fails, or is still loading,data
will beundefined
. So using!
is not the right solution as that is only reserved for whendata
is guaranteed to be defined by the programmer.Instead, show a warning to the user that explains that the prettier config couldn't be loaded and therefore the code won't be formatted when saving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's type of warning for user?
such as https://mui.com/material-ui/react-alert/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there component that i can directly invoke ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An Alert could work. I'd have to see what it looks like. For me I think it's important it's inline, close enough to the save button (i.e. no popup)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be a problem while prettier tries to access the file system, or a bug in our code, or in prettier, or our bundler could have transformed the code wrong, or it could be running on an incompatible node.js runtime that we're unaware about, a solar storm flipping a bit,... anything really 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
do these errors need to be passed to front-end, if back-end occurs error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Janpot
please make a final check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JerryWu1234
useQuery
is a wrapper aroundreact-query
. Next to thedata
property it will return anerror
property.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice point out.
before I thought we need to add a
try catch
and then pass to front end. lolI will do it late