[core] Fix Vale errors #4347
Merged
[core] Fix Vale errors #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
This was referenced Nov 1, 2024
oliviertassinari
commented
Nov 1, 2024
| Create a layout file for your dashboard pages (e.g., `app/(dashboard)/layout.tsx`): | ||
| Create a layout file for your dashboard pages (for example, `app/(dashboard)/layout.tsx`): |
There was a problem hiding this comment.
This was reported in https://github.com/mui/toolpad/pull/4080/files#diff-8223eb12de217e7e039331fde50c24a9cb7cc57e87c6982b28dc268dad0080b4
See PR description (mui/mui-public#226 (comment)) for why it didn't break the CI.
| The `<Account />` component is composed of multiple sub-components: | ||
| The `<Account />` component is composed of multiple subcomponents: |
There was a problem hiding this comment.
This was reported in https://github.com/mui/toolpad/pull/4181/files
See PR description (mui/mui-public#226 (comment)) for why it didn't break the CI.
bharatkashyap
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors reported by
vale sync && git ls-files | grep -h -E ".(mdx|md)$" | xargs vale --filter='.Level=="error"'.The CI should fail for them but it's not working today. @vladmoroz I have cleaned up mui/mui-public#226 to provide details on what's going on here.
I noticed this problem on #4344.