-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix Vale errors #4347
Merged
Merged
[core] Fix Vale errors #4347
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,12 +53,12 @@ You can find details on the `AppProvider` props on the [AppProvider](/toolpad/co | |
:::info | ||
The `AppRouterCacheProvider` component is not required to use Toolpad Core, but it's recommended to use it to ensure that the styles are appended to the `<head>` and not rendering in the `<body>`. | ||
|
||
See the [Material UI Next.js integration docs](https://mui.com/material-ui/integrations/nextjs/) for more details. | ||
See the [Material UI Next.js integration docs](https://mui.com/material-ui/integrations/nextjs/) for more details. | ||
::: | ||
|
||
### 2. Create a dashboard layout | ||
|
||
Create a layout file for your dashboard pages (e.g., `app/(dashboard)/layout.tsx`): | ||
Create a layout file for your dashboard pages (for example, `app/(dashboard)/layout.tsx`): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was reported in https://github.com/mui/toolpad/pull/4080/files#diff-8223eb12de217e7e039331fde50c24a9cb7cc57e87c6982b28dc268dad0080b4 See PR description (mui/mui-public#226 (comment)) for why it didn't break the CI. |
||
|
||
```tsx title="app/(dashboard)/layout.tsx" | ||
import * as React from 'react'; | ||
|
@@ -261,7 +261,7 @@ To integrate Toolpad Core into your Next.js Pages Router app, follow these steps | |
|
||
### 1. Wrap your application with `AppProvider` | ||
|
||
In your root layout file (e.g., `pages/_app.tsx`), wrap your application with the `AppProvider`: | ||
In your root layout file (for example, `pages/_app.tsx`), wrap your application with the `AppProvider`: | ||
|
||
```tsx title="pages/_app.tsx" | ||
import * as React from 'react'; | ||
|
@@ -357,7 +357,7 @@ Document.getInitialProps = async (ctx: DocumentContext) => { | |
|
||
### 3. Add a dashboard page | ||
|
||
Create a dashboard page (e.g., `pages/index.tsx`): | ||
Create a dashboard page (for example, `pages/index.tsx`): | ||
|
||
```tsx title="pages/index.tsx" | ||
import * as React from 'react'; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was reported in https://github.com/mui/toolpad/pull/4181/files
See PR description (mui/mui-public#226 (comment)) for why it didn't break the CI.