Mptcp reset option #45
Conversation
This adds the 'mp_reset' keyword to allow sending packets with TCPRST suboption. Examples: 1.0 R. 1:1(0) ack 1001 win 264 <mp_reset 1> 1.0 R. 1:1(0) ack 1001 win 264 <mp_reset 1 flags [ flag_t ]> Signed-off-by: Florian Westphal <fw@strlen.de>
|
patch LGTM. @matttbe, we might merge this PR first, and then fix |
@dcaratti Sounds good to me! Note that if you want, we can also rebase this PR 45 on top of 46. You should also have the right to push to the mptcp_reset_option branch on fw-strlen/packetdrill repo ;-) |
matttbe
force-pushed
the
mptcp_reset_option
branch
from
26aadab
to
0d2e6fd
Compare
|
Hi Florian, Thank you for these patches! I hope you don't mind, I just modified the scripts you added to follow the structures of the others: https://github.com/multipath-tcp/packetdrill/compare/26aadab2df2b1ed824f5c0001305158e1c83e069..0d2e6fd606c38c013ffe8bcb28bd4a339611802a For me, it helps to read and review them but we can of course change that if it is a problem. |
mp_reset_multi_v4.pkt - check we can reset a subflow and mptcp connection is unaffected. mp_reset_single.pkt - check we can reset single subflow. Check mp_reset on non-RST packets has no effect. mp_reset_single_tcp.pkt - check TCP doesn't care about mp_reset presence. This also "fixes" existing test cases to expect mp_reset option in some cases. Signed-off-by: Florian Westphal <fw@strlen.de>
matttbe
force-pushed
the
mptcp_reset_option
branch
from
0d2e6fd
to
f24a513
Compare
There was a problem hiding this comment.
Hi Florian,
Thank you for the patches!
I just did another modification to add --tolerance_usec option missing in one test.
https://github.com/multipath-tcp/packetdrill/compare/0d2e6fd606c38c013ffe8bcb28bd4a339611802a..f24a51364f9c1f0918dde8c050ad9087dbe6e279
The rest looks good to me!
@dcaratti is it also OK for you? Especially the modification of the parser and others :)
Cheers,
Matt
|
@dcaratti arf, sorry, I forgot you already said "LGTM" :) All good then, just have to wait for the kernel patches to be merged first then :) |
This extends packetdrill with support for the mptcp reset option. Also adds test cases for the reset option and updates affected mptcp test cases to expect presence of the mptcp reset option. This needs mptcp-next kernel with mptcp reset option support.