Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc/v1.7.next1 in feat/esdt improvements 28mar #6072

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

ssd04 and others added 30 commits February 21, 2024 11:44
Add missing state statistics field to config file
…ets-refactor

Chain simulator initial wallets refactor
iulianpascalau and others added 25 commits March 14, 2024 16:57
…simulator

Applied custom arch config tweaks on the chain simulator
…cenario

Added stake-unstake-unbond scenario + EEI fix
…tion

remove all nodes from queue on the activation of staking v4.
…factor

Uniformized the calling methods for integration tests
….03.20

Merge master into rc170 2024.03.20
…024.03.21

Merge rc170 into rc17next1 2024.03.21
…7.next1-in-feat/esdt-improvements-28mar

# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	common/constants.go
#	common/enablers/enableEpochsHandler.go
#	common/enablers/enableEpochsHandler_test.go
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	vm/errors.go
#	vm/systemSmartContracts/esdt.go
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 84.80433% with 365 lines in your changes are missing coverage. Please review.

Project coverage is 78.84%. Comparing base (d62daea) to head (9ff5a69).

Files Patch % Lines
epochStart/metachain/legacySystemSCs.go 71.99% 118 Missing and 108 partials ⚠️
factory/api/apiResolverFactory.go 81.25% 19 Missing and 2 partials ⚠️
epochStart/metachain/auctionListDisplayer.go 87.40% 9 Missing and 7 partials ⚠️
factory/processing/blockProcessorCreator.go 83.56% 6 Missing and 6 partials ⚠️
epochStart/metachain/systemSCs.go 85.13% 8 Missing and 3 partials ⚠️
epochStart/bootstrap/baseStorageHandler.go 37.50% 5 Missing and 5 partials ⚠️
genesis/process/genesisBlockCreator.go 63.63% 5 Missing and 3 partials ⚠️
epochStart/metachain/auctionListSelector.go 97.13% 5 Missing and 2 partials ⚠️
epochStart/metachain/common.go 0.00% 7 Missing ⚠️
epochStart/metachain/tableDisplayer.go 36.36% 7 Missing ⚠️
... and 13 more
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat/esdt-improvements    #6072      +/-   ##
==========================================================
- Coverage                   79.92%   78.84%   -1.09%     
==========================================================
  Files                         731      752      +21     
  Lines                       96584    98254    +1670     
==========================================================
+ Hits                        77198    77466     +268     
- Misses                      13973    15555    +1582     
+ Partials                     5413     5233     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeniaminDrasovean BeniaminDrasovean merged commit c3383ee into feat/esdt-improvements Mar 28, 2024
6 of 7 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the merge-rc/v1.7.next1-in-feat/esdt-improvements-28mar branch March 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants