Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds lsp document symbol provider #293

Closed

Conversation

baszalmstra
Copy link
Collaborator

Adds an LSP document symbol provider. The result is based on the AST of a SourceFile. The implementation is adapted from the rust-analyzer code.

image

@baszalmstra baszalmstra added type: feat New feature or request pri: low An issue with no impact to quality, performance, or functionality labels Jan 3, 2021
@baszalmstra baszalmstra requested a review from Wodann January 3, 2021 20:56
@baszalmstra baszalmstra self-assigned this Jan 3, 2021
@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #293 (3a0bdaa) into master (30bfe19) will increase coverage by 1.31%.
The diff coverage is 83.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
+ Coverage   79.51%   80.83%   +1.31%     
==========================================
  Files         228      230       +2     
  Lines       13425    13587     +162     
==========================================
+ Hits        10675    10983     +308     
+ Misses       2750     2604     -146     
Impacted Files Coverage Δ
crates/mun_language_server/src/cancelation.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/capabilities.rs 0.00% <0.00%> (ø)
crates/mun_language_server/src/lib.rs 0.00% <0.00%> (ø)
crates/mun_syntax/src/lib.rs 63.04% <ø> (ø)
crates/mun_language_server/src/main_loop.rs 64.04% <73.84%> (+40.23%) ⬆️
crates/mun_language_server/tests/support.rs 83.11% <86.48%> (+1.48%) ⬆️
crates/mun_language_server/src/analysis.rs 100.00% <100.00%> (+75.00%) ⬆️
crates/mun_language_server/src/conversion.rs 60.00% <100.00%> (+60.00%) ⬆️
crates/mun_language_server/src/file_structure.rs 100.00% <100.00%> (ø)
...tes/mun_language_server/src/protocol/connection.rs 31.25% <100.00%> (+2.08%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30bfe19...3a0bdaa. Read the comment docs.

@baszalmstra
Copy link
Collaborator Author

Im gonna write some tests. Dont merge yet ;)

@baszalmstra
Copy link
Collaborator Author

I ran into a bunch of issues with the VFS. These things have been fixed in #294 . I will rebase this PR on that one.

@baszalmstra
Copy link
Collaborator Author

This has been superseded by #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pri: low An issue with no impact to quality, performance, or functionality type: feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant