-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(lsp): implements incremental file updates #298
feature(lsp): implements incremental file updates #298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
==========================================
+ Coverage 80.80% 80.82% +0.01%
==========================================
Files 240 241 +1
Lines 14584 14131 -453
==========================================
- Hits 11785 11421 -364
+ Misses 2799 2710 -89
Continue to review full report at Codecov.
|
Once the previous LSP PR is merged, can you rebase this? Quite a lot of files to re-review otherwise 😅 |
dbc892f
to
d36c727
Compare
d36c727
to
13d722f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially reviewed. I'll to review the remainder of this tomorrow
@@ -88,6 +237,24 @@ mod tests { | |||
); | |||
assert_eq!(index.text_part(0, 2, &text, text_len), Some(text)); | |||
} | |||
#[test] | |||
fn test_text_part_utf16() { | |||
let text = "a\n❤️\nb"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the emoji a UTF-16 character, but not a UTF-8 character?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baszalmstra, I'm just trying to understand the transition from UTF-8 to UTF-16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple more requests
db2129e
to
12d006f
Compare
12d006f
to
f9634bb
Compare
Enables the language server to receive incremental file updates when text is being modified in an editor.
I bumped the rowan and text_unit crates. They output syntax and text range a bit different which causes all the changes in a lot of tests.
I also cleaned up conversion from lsp types to our types. Functions are now split over the
to_lsp
andfrom_lsp
modules.Depends on #293