Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Volume control #830

Closed
Peppershade opened this issue Nov 16, 2022 · 5 comments · Fixed by #994
Closed

Enhancement: Volume control #830

Peppershade opened this issue Nov 16, 2022 · 5 comments · Fixed by #994

Comments

@Peppershade
Copy link

I love the project, however we cannot use it in our setup because there is no volume control. Is there a chance it will be added in the future?
We use Discord with a listening bot to make the audio available on a speaker system using a Raspberry Pi, however we cannot access the volume from there easily.

@codetheweb
Copy link
Collaborator

That's an interesting use case. I generally feel that volume controls are unnecessary bloat at best or actively hostile at worst (if the bot owner chooses a default volume that doesn't work for >50% of listeners), but I see how it'd be useful in your case.

No guarantees that I'll accept a PR for this but if you (or someone else) prepares a PR I'll take a look.

@matiasba
Copy link

matiasba commented Jan 3, 2024

Really hope that something like this could be added in the future. I really like the bot but the default volume seems really loud for everyone in my server.

@Raecaug
Copy link

Raecaug commented Jan 4, 2024

I believe this can already be tweaked on a per-user basis via this method.

FoxxMD added a commit to FoxxMD/muse that referenced this issue Feb 2, 2024
* Enabled using env VOLUME_CONTROL=true
* Disabled by default
@FoxxMD
Copy link
Contributor

FoxxMD commented Feb 2, 2024

@matiasba I've got a PR in for this. You can try using docker image foxxmd/muse:latest with the additional env VOLUME_CONTROL=true added to your run command.

FoxxMD added a commit to FoxxMD/muse that referenced this issue Feb 7, 2024
* Enabled using env VOLUME_CONTROL=true
* Disabled by default

Persist volume level on player
FoxxMD added a commit to FoxxMD/muse that referenced this issue Feb 14, 2024
codetheweb added a commit that referenced this issue Mar 13, 2024
Co-authored-by: Max Isom <hi@maxisom.me>
Copy link

🚀 Released in Release v2.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants