Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Issue] Option to disable Backup feature is missing in MS4 #14973

Closed
LoveJessyChen opened this issue Dec 6, 2022 · 16 comments · Fixed by #25178
Closed

[MU4 Issue] Option to disable Backup feature is missing in MS4 #14973

LoveJessyChen opened this issue Dec 6, 2022 · 16 comments · Fixed by #25178
Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2)

Comments

@LoveJessyChen
Copy link

LoveJessyChen commented Dec 6, 2022

Bug:

Option to disable Backup feature (like in MS3) is missing in MS4

2022-12-05_22

Also see comment

Platform information
macOS 13.0.1

Additional content
#23386

@LoveJessyChen LoveJessyChen changed the title [MU4 Issue] Too set .mscbackup to another directory or disable this backup [MU4 Issue] To set .mscbackup to another directory or disable this backup Dec 6, 2022
@Tantacrul
Copy link
Contributor

This is an MS3.6 issue, right?

@LoveJessyChen
Copy link
Author

This is an MS3.6 issue, right?

No ,I want to add this 3.6's feature to version of 4.0

@Tantacrul
Copy link
Contributor

I have unfortunately very little idea what it is you are suggesting actually - although I suspect some other community folk may know better than I. @MarcSabatella - any idea what this is? I'm sure it's something we discussed 2 years ago or so but it has escaped me now

@MarcSabatella
Copy link
Contributor

@Tantacrul MuseScore has always made an automatic backup copy of your score when you first save it during a session. it also autosaves a separate copy every few minutes to use in recovering from a crash. At some point in the last few years, someone decided to add options to allow the user to specify where these backups are stored, and also, to disable the automatic backups completely.

Frankly, I'm not sure what the purpose of either of those options would be, really - seems like asking for trouble for me. But a few users seemed to think it would help them somehow. And this option is not present in MU4. Backups are always made, and their location is not changeable.

@Tantacrul Tantacrul added the P3 Priority: Low label Dec 6, 2022
@Tantacrul
Copy link
Contributor

@LoveJessyChen - can I ask why you would want this feature?

@LoveJessyChen
Copy link
Author

LoveJessyChen commented Dec 6, 2022

This is my reason of this features: When I move original mscz files to other new folder, the Backup FILES WILL REMAIN in old folder . This is meaningless and uses my memory of the disks.

@Tantacrul
Copy link
Contributor

Ah! So you're actually reporting a bug here.

Let me try that...

@MarcSabatella
Copy link
Contributor

MarcSabatella commented Dec 6, 2022

I don't see that as a bug - when you move a file to another folder using your OS file browser, there is no way the system could know to move the backup along with it. Nor should it, necessarily. You are certainly welcome to move the backups manually, or delete them, of course.

Score files are quite small normally, there should be very little concern about disk space just from a single backup file per score. But if for whatever reason that is a concern, disabling backup would be sufficient to address it. I am still not seeing the point of overriding the default location for them.

@Tantacrul
Copy link
Contributor

Tantacrul commented Dec 6, 2022

Yeah, I'm trying to figure out repro steps and can't get to any issue. For sure, if you move a score while it is open in MS, the the autosaved file naturally doesn't move with it. I don't get it.

@cbjeukendrup
Copy link
Contributor

@Tantacrul It's quite simple, but only if you have turned on "Show hidden folders" in Finder :) You can do this by pressing Cmd + Shift + . (dot).

  1. Create a score. Save it in folder X.
  2. Modify the score and save the changes.
  3. In Finder, you see that a folder .mscbackup is created inside folder X. Inside this folder, there is a backup of the file (this backup contains the state of the file before saving, which is indeed how it should work, but that doesn't matter for this story)
  4. Close the file in MuseScore.
  5. Move the file to folder Y.
  6. Open the file from folder Y in MuseScore.
  7. Modify the score and save the changes.
  8. In Finder, you see that another .mscbackup folder is created inside folder Y, which contains again a pre-save backup of the file. This is all correct so far.

What's being discussed here, is what should happen with the old backup inside folder X, which continues to exist.

I don't think we should try to delete that, since that would make the backup feature less reliable. Furthermore, it would be impossible, because MuseScore cannot detect that you moved the file on your computer (it sees no relation between the old and new path). I really think we should not try to fix this, as it can only cause bigger trouble. In fact I think it's not a bug, but rather an unfortunate fact of life.

However, I do think we should provide an option to disable the backup feature, for people who care about that tiny bit of wasted disk space. Also, especially on macOS, you might argue that the backup feature is somewhat redundant since you already have Time Machine, the system wide backup solution. (Of course, I know that this works quite differently from MuseScore's backup feature, but still.) Therefore I think we should provide the option to disable backups, just in Preferences > Advanced, like in MS 3.6.2.

@cbjeukendrup cbjeukendrup reopened this Dec 6, 2022
@cbjeukendrup cbjeukendrup added the feature request Used to suggest improvements or new capabilities label Jul 4, 2023
@DmitryArefiev
Copy link
Contributor

However, I do think we should provide an option to disable the backup feature, for people who care about that tiny bit of wasted disk space. Also, especially on macOS, you might argue that the backup feature is somewhat redundant since you already have Time Machine, the system wide backup solution. (Of course, I know that this works quite differently from MuseScore's backup feature, but still.) Therefore I think we should provide the option to disable backups, just in Preferences > Advanced, like in MS 3.6.2.

@bkunda I agree with Casper, some users may want to disable backups and not create .mscbackup hidden folder on their disk drives. We can easily put the main option (generateBackup checkbox) to Preferences>Advanced (like in MS3.6.2):
205800841-2f175673-c62b-4627-a429-c1c871a957b7

Capture

And actually, it's not a feature request it's a bug (missing MS3 functionality)

@DmitryArefiev DmitryArefiev added P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2) community Issues particularly suitable for community contributors to work on and removed P3 Priority: Low feature request Used to suggest improvements or new capabilities labels Jun 28, 2024
@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Jun 30, 2024

To set .mscbackup to another directory

This is logged separately (#23386)

I'll modify the summary and description

@DmitryArefiev DmitryArefiev changed the title [MU4 Issue] To set .mscbackup to another directory or disable this backup [MU4 Issue] Option to disable Backup feature is missing in MS4 Jun 30, 2024
@LoveJessyChen
Copy link
Author

When will this issue solve? I have waited it 3 years.

@cbjeukendrup cbjeukendrup added the good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute label Oct 12, 2024
@cbjeukendrup
Copy link
Contributor

Since this is a relatively niche and uncommon request, we cannot give it a very high priority of course. Currently there is no concrete schedule for this issue.
Contributors are welcome to work on this, since it is unlikely that the internal team will work on this within the next few months.

@LoveJessyChen
Copy link
Author

LoveJessyChen commented Oct 15, 2024

OK I will not use MS4 till ms5 released.

@cbjeukendrup
Copy link
Contributor

A new version number isn't going to change much about this issue. However, this Pull Request, made by a contributor, is: #25178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues particularly suitable for community contributors to work on good first issue Issues suitable for first-time contributors. See https://github.com/musescore/MuseScore/contribute P2 Priority: Medium regression MS3 Regression from MS3 (3.6.2)
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants