Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Disable Backup Option #25178

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Added Disable Backup Option #25178

merged 2 commits into from
Oct 18, 2024

Conversation

shubham-shinde-442
Copy link
Contributor

Resolves: #14973

Added Option for disable backup in Preferences->Advanced.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

cbjeukendrup
cbjeukendrup reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue!

src/project/internal/projectconfiguration.cpp Outdated Show resolved Hide resolved
src/project/internal/projectconfiguration.cpp Outdated Show resolved Hide resolved
@cbjeukendrup cbjeukendrup mentioned this pull request Oct 16, 2024
Closed
@shubham-shinde-442
Copy link
Contributor Author

@cbjeukendrup Updated now.

cbjeukendrup
cbjeukendrup approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@cbjeukendrup
Copy link
Contributor

VTest failure is unrelated; a rebase would fix it, but I don't think it's important

@zacjansheski
Copy link
Contributor

Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved
#14973 FIXED

@RomanPudashkin RomanPudashkin merged commit 0cf2ba1 into musescore:master Oct 18, 2024
10 of 11 checks passed
@shubham-shinde-442 shubham-shinde-442 deleted the disable_backup branch October 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

Assignees

@zacjansheski zacjansheski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Option to disable Backup feature is missing in MS4
4 participants
@shubham-shinde-442 @cbjeukendrup @zacjansheski @RomanPudashkin