-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accelerate
not working with synths
#254
Comments
Perhaps it was this change: |
superchip uses a UGen that emulates an old home computer synth chip, and that UGen takes a frequency divider as input for pitch control just like the original hardware. Anyway, I'm not surprised if some change to freq scaling broke the conversion. But accelerate should certainly be doing something with other synths, I'll take a look and see if I can figure out what's going on. |
Just to report, it works on my machine:
When we introduced |
It seems that all applications of `DirtFreqScale` in `library/default-synths-extra.scd` are without effect: the parameter `speedFreq` is not passed, and it's default value is 0, effectively deactivating frequency scaling. As `DirtFreqScale` is used nowhere else, I propose to change the default value of `speedFreq` to 1. Per musikinformatik#247, this should recover the old behavior of `accelerate`, fixing musikinformatik#254.
has previously accelerated the note in the superchip synth (I've also tried a bunch of other synths, samples do work).
My testing environments use:
develop
andmaster
3.11.2+repack-focal1
(manual backport) and3.10.0+repack-1ubuntu2
(from repos)Other users who've verified the problem use both Windows and OSX, on the superdirt
master
branch.Some users have reported it working (on SC 3.12.1, SD
master
, arch and win10)The last record of it working I have was a livestream I did in Sept 2020:
https://youtu.be/_uASsk8nHvQ?t=446
A stream from the following month and it seems to not be working (I think I assumed I was doing something wrong, but forgot to follow up):
https://youtu.be/kliiBKWWy4w?t=233
The text was updated successfully, but these errors were encountered: