Apply DirtFreqScale to default synths #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uhm... that's my job email, don't know from where it came out :) |
Closed
|
I've deleted it. :) |
ndr-brt
added a commit
to ndr-brt/SuperDirt
that referenced
this pull request
Jan 3, 2022
Apply DirtFreqScale to default synths
wimmers
added a commit
to wimmers/SuperDirt
that referenced
this pull request
Dec 1, 2022
It seems that all applications of `DirtFreqScale` in `library/default-synths-extra.scd` are without effect: the parameter `speedFreq` is not passed, and it's default value is 0, effectively deactivating frequency scaling. As `DirtFreqScale` is used nowhere else, I propose to change the default value of `speedFreq` to 1. Per musikinformatik#247, this should recover the old behavior of `accelerate`, fixing musikinformatik#254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #242