Add return type declaration for "equals()" method #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-foremski
force-pushed
the
add_return_types
branch
from
26195bb to
3b8c6d4
Compare
|
Done |
|
Damn I didn't think about this before now but adding return types is a BC break in case anyone has extended the class. See https://3v4l.org/4DKvY for example. However the |
jacek-foremski
force-pushed
the
add_return_types
branch
from
3b8c6d4 to
d631995
Compare
jacek-foremski
changed the title
|
Ok, I reduced the scope to |
peter279k
approved these changes
Apr 23, 2019
|
Thank you, let's do this! |
shadowhand
reviewed
Apr 23, 2019
| @@ -87,7 +87,7 @@ public function __toString() | |||
| * | |||
| * @return bool | |||
| */ | |||
| final public function equals($variable = null) | |||
| final public function equals($variable = null): bool | |||
There was a problem hiding this comment.
What about adding other return types?
There was a problem hiding this comment.
Please read the discussion above (basically it would be a BC break)
There was a problem hiding this comment.
Ah, okay. Still working on my first cup of ☕️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds return type declarations where applicable.
I required PHP 7.2, because it's the last version still in active support. This of course can be changed based on how maintainers prefer it.
One of the two PRs needed to fix #86