[WIP] build: fix GOPATH shadow bug #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
shadow_bug
branch
2 times, most recently
from
c12d5e6 to
c7f88fb
Compare
Previously, we incorrectly determined cache staleness based on the unaugmented files of a package. e.g. where there are special overrides for various packages, these we not being taken into account. Now we do take that into account, but at the slight cost of also unconditionally parsing each file in the process (the code that augments a package is rather tightly coupled to the parsing, so we leave that alone). We also do not cache test packages either.
build: fix GOPATH shadow bug Fixes #27
|
This will now be fixed in #33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27