build: almost complete module support #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
fix_cache
branch
21 times, most recently
from
bbf835f to
d1e28e8
Compare
myitcv
changed the title
myitcv
force-pushed
the
fix_cache
branch
3 times, most recently
from
5618685 to
0a4a43e
Compare
This is a necessarily large PR to offer almost complete Go modules support for GopherJS. * We now use github.com/rogpeppe/go-internal to be able to write testscript tests * A suite of testscript tests have been added to cover the major GopherJS commands operating in both GOPATH mode and module mode. Includes a test to ensure that the bug raised in #27 is now properly fixed. * The GopherJS tool and build packages have been heavily refactored in places to support Go modules. GopherJS support for Go modules follows the same patterns as the go tool. * We fix the build cache to be a function of the augmented packages as opposed (incorrectly) to the unaugmented package files. This has a slight cost because of the way the augmentation code is currently written (this could be refactored in a later PR) because every file is unconditionally parsed. Main and test packages are not cached (again, we could change this in a later PR). Because it would just work. * We fix the tests/run.go wrapper around the fixedbugs tests in the Go distribution to not perform a chdir into GOROOT; this does not work with modules. * We tidy up .circleci/config.yml to split commands into their separate run sections where it makes sense to. * We add genmodstubbs.go to automatically populate the stubs we need in testdata/mod for the loading of github.com/gopherjs/gopherjs/{js,nosync}. * For a more current commentary on the Go module support in GopherJS see https://github.com/myitcv/gopherjs/wiki/Changes-in-module-aware-GopherJS Fixes #24 Fixes #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a necessarily large PR to offer almost complete Go modules
support for GopherJS.
tests
commands operating in both GOPATH mode and module mode. Includes a test to
ensure that the bug raised in package in GOPATH shadows module #27 is now properly fixed.
support Go modules. GopherJS support for Go modules follows the same patterns
as the go tool.
(incorrectly) to the unaugmented package files. This has a slight cost because
of the way the augmentation code is currently written (this could be refactored
in a later PR) because every file is unconditionally parsed. Main and test
packages are not cached (again, we could change this in a later PR). Because it
would just work.
distribution to not perform a chdir into GOROOT; this does not work with
modules.
sections where it makes sense to.
testdata/mod for the loading of github.com/gopherjs/gopherjs/{js,nosync}.
https://github.com/myitcv/gopherjs/wiki/Changes-in-module-aware-GopherJS
Fixes #24
Fixes #27