perf(admin): only save product settings once per request #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
============================================
- Coverage 51.96% 48.15% -3.81%
+ Complexity 692 561 -131
============================================
Files 152 148 -4
Lines 4191 3721 -470
Branches 55 55
============================================
- Hits 2178 1792 -386
+ Misses 1958 1874 -84
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joerivanveen
approved these changes
Oct 10, 2024
FlorianSDV
approved these changes
Oct 11, 2024
myparcel-bot
bot
force-pushed
the
perf/saving-product-settings
branch
from
d1338d4
to
edacec9
Compare
|
✅ Build successful! You can find a link to the downloadable artifact below. |
myparcel-bot
bot
force-pushed
the
perf/saving-product-settings
branch
3 times, most recently
from
7255150
to
6ebe2ff
Compare
myparcel-bot
bot
force-pushed
the
perf/saving-product-settings
branch
2 times, most recently
from
a0fdc37
to
5e7b425
Compare
myparcel-bot
bot
force-pushed
the
perf/saving-product-settings
branch
from
5e7b425
to
d24acd5
Compare
myparcel-bot bot
added a commit
that referenced
this pull request
Oct 30, 2024
## [4.1.0](v4.0.0...v4.1.0) (2024-10-30) ### 🐛 Bug Fixes * fix error on install due to usage of `use` in factory closure ([#283](#283)) ([1b4fdca](1b4fdca)), closes [#281](#281) ### ⚡ Performance Improvements * **admin:** only save product settings once per request ([#279](#279)) ([e60bce1](e60bce1)) ### ✨ New Features * **deps:** upgrade @myparcel-pdk/* ([0cd4941](0cd4941)) * **deps:** upgrade myparcelnl/pdk to v2.45.0 ([6ff668d](6ff668d))
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.